fix review · page comments
A comment now survives opening its screenshot
Pressing Escape on a screenshot's preview used to close the page comment it was attached to. I recorded one journey before and after the fix. Choose a moment, then switch recordings to see the same step in the other.
Waiting for a Playwright recording.
Waiting for a Playwright recording.
Ship the fix?
The recordings part at Back from the preview. Before the fix the comment is gone and focus is on the page; after it the comment is back with its words and screenshot, and the thumbnail holds focus.
The recordings show Escape in Chrome. The regression test also closes the preview with its close button and with a press outside it, in the page comment and in a thread reply in the floating panel, and fails on each without the fix.
The comment and its focus come back however the preview closes.
Add a pair of recordings of a thread reply, whose view closed for a different reason, and ship after you have watched them.
Why the comment closed
The page comment card is an auto popover, and opening a modal dialog closes every auto popover the dialog does not stand in. The image preview is a modal dialog, so opening it closed the card, and closing it left focus on the page. The preview now stands inside the open card while it is shown and returns to its usual place when it closes.